KAFKA-19064: Handle exceptions from deferred events in coordinator #19333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously in KAFKA-18484, we added exception handling for exceptions coming from batch events. Also handle exceptions from 0-record write events and transaction completion events.
|
Depends upon #19332 and won't compile without it. |
dajac
reviewed
Apr 1, 2025
| runtime.scheduleLoadOperation(TP, 10); | ||
| CoordinatorRuntime<MockCoordinatorShard, String>.CoordinatorContext ctx = runtime.contextOrThrow(TP); | ||
|
|
||
| // Get the max batch size. |
There was a problem hiding this comment.
I wonder why we changed the old test vs adding a new one for the new discovered cases. Is the old test not necessary any more?
There was a problem hiding this comment.
I put all three cases in the same test.
Previously, write#2 existed to test the exception handling (it would not be completed if there was none) and write#3 triggered a flush. Write#2 is unnecessary in the unload case and the flush is now triggered by the transaction completion.
janchilling
pushed a commit
to janchilling/kafka
that referenced
this pull request
Apr 4, 2025
…pache#19333) Previously in KAFKA-18484, we added exception handling for exceptions coming from batch events. Also handle exceptions from 0-record write events and transaction completion events. Reviewers: David Jacot <djacot@confluent.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in KAFKA-18484, we added exception handling for exceptions
coming from batch events. Also handle exceptions from 0-record write
events and transaction completion events.
Reviewers: David Jacot djacot@confluent.io