KAFKA-18683: Handle slicing of file records for updated start position #18759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoorvmittal10
added
ci-approved
and removed
triage
apoorvmittal10
force-pushed
the
file-records-slice
branch
from
eaf06e8 to
2848ad2
Compare
apoorvmittal10
changed the title
apoorvmittal10
force-pushed
the
file-records-slice
branch
from
2848ad2 to
edec697
Compare
junrao
approved these changes
Jan 31, 2025
pdruley
pushed a commit
to pdruley/kafka
that referenced
this pull request
Feb 12, 2025
apache#18759) The PR corrects the check which was introduced in apache#5332 where position is checked to be within boundaries of file. The check position > currentSizeInBytes - start is incorrect, since the position is relative to start. Reviewers: Jun Rao <junrao@gmail.com>
manoj-mathivanan
pushed a commit
to manoj-mathivanan/kafka
that referenced
this pull request
Feb 19, 2025
apache#18759) The PR corrects the check which was introduced in apache#5332 where position is checked to be within boundaries of file. The check position > currentSizeInBytes - start is incorrect, since the position is relative to start. Reviewers: Jun Rao <junrao@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR corrects the check which was introduced in #5332 where
positionis checked to be within boundaries of file. However the checkposition > currentSizeInBytes - start:start, andsizeof the slice is lesser thanstartposition.positionis relative tostarthence there can be data which could be further sliced but asstartis subtracted fromsizethen it might fail.This PR avoids subtracting
startfrom availablesizeas thepositionfor slicing is already relative to the start hence just checking if thepositionis lesser than thesizeconfirms the boundary.