Skip to content

KAFKA-18557 ShareCoordinatorServiceTest can leverage ShareCoordinatorTestConfig#testConfig to streamline codebase #18582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2025
Merged

KAFKA-18557 ShareCoordinatorServiceTest can leverage ShareCoordinatorTestConfig#testConfig to streamline codebase #18582

merged 1 commit into from
Jan 17, 2025

Conversation

@mingdaoy
Copy link
Contributor

@mingdaoy mingdaoy commented Jan 16, 2025

https://issues.apache.org/jira/browse/KAFKA-18557

Replace createConfig(ShareCoordinatorTestConfig.testConfigMap()) with testConfig()

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@github-actions github-actions bot added triage PRs from the community tests Test fixes (including flaky tests) KIP-932 Queues for Kafka small Small PRs labels Jan 16, 2025
@mingdaoy mingdaoy changed the title KAFKA-18557 ShareCoordinatorServiceTest can leverage ShareCoordinatorTestConfig#testConfig to streamline the codebase KAFKA-18557 ShareCoordinatorServiceTest can leverage ShareCoordinatorTestConfig#testConfig to streamline codebase Jan 16, 2025
AndrewJSchofield
AndrewJSchofield approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@AndrewJSchofield AndrewJSchofield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good to me.

@AndrewJSchofield AndrewJSchofield merged commit 042da16 into apache:trunk Jan 17, 2025
10 checks passed
@github-actions github-actions bot removed the triage PRs from the community label Jan 18, 2025
pranavt84 pushed a commit to pranavt84/kafka that referenced this pull request Jan 27, 2025
@mingdaoy @pranavt84
KAFKA-18557 streamline codebase with testConfig() (apache#18582)
4cb0940 
Reviewers: Andrew Schofield <aschofield@confluent.io>
airlock-confluentinc bot pushed a commit to confluentinc/kafka that referenced this pull request Jan 27, 2025
@mingdaoy @mjsax
KAFKA-18557 streamline codebase with testConfig() (apache#18582)
e90e999 
Reviewers: Andrew Schofield <aschofield@confluent.io>
manoj-mathivanan pushed a commit to manoj-mathivanan/kafka that referenced this pull request Feb 19, 2025
@mingdaoy @manoj-mathivanan
KAFKA-18557 streamline codebase with testConfig() (apache#18582)
448340c 
Reviewers: Andrew Schofield <aschofield@confluent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndrewJSchofield AndrewJSchofield AndrewJSchofield approved these changes

Assignees

No one assigned

Labels

ci-approved KIP-932 Queues for Kafka small Small PRs tests Test fixes (including flaky tests)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mingdaoy @AndrewJSchofield @chia7712