Skip to content

Conversation

@frankvicky
Copy link
Contributor

@frankvicky frankvicky commented Dec 4, 2024

JIRA: KAFKA-18131

Currently, the log of LeaderState#timeUntilCheckQuorumExpires uses streams without a terminal operator, resulting in output like java.util.stream.ReferencePipeline$3@39660237.
This PR aims to fix this issue and improve the log message.

log after this PR:

[2024-12-04 17:40:06,184] INFO Did not receive fetch request from the majority of the voters within 3000ms. Current fetched voters are [3], and voters are [ReplicaKey(id=3, directoryId=Viibdq8iQpWShRTAzqWS4Q), ReplicaKey(id=4, directoryId=0fYZLl_RSXyW9pD51y-SSA), ReplicaKey(id=2, directoryId=TszqnKezTXKIKZt5aJl32A), ReplicaKey(id=0, directoryId=HSOI7G7iTBOd3aSG7us-Sg), ReplicaKey(id=1, directoryId=OdpwGEzaQcSrW8qP6bXU6Q)] (org.apache.kafka.raft.LeaderState:154)
[2024-12-04 17:40:06,201] INFO Did not receive fetch request from the majority of the voters within 3000ms. Current fetched voters are [3], and voters are [ReplicaKey(id=2, directoryId=<undefined>), ReplicaKey(id=3, directoryId=<undefined>), ReplicaKey(id=4, directoryId=<undefined>), ReplicaKey(id=0, directoryId=<undefined>), ReplicaKey(id=1, directoryId=<undefined>)] (org.apache.kafka.raft.LeaderState:154)

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@frankvicky
Copy link
Contributor Author

Hi @showuon
Could you please take a look when you have some time ?
Many thanks 😺

Copy link
Member

@showuon showuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the improvement.

@showuon showuon merged commit 2e4a378 into apache:trunk Jan 6, 2025
8 of 9 checks passed
tedyu pushed a commit to tedyu/kafka that referenced this pull request Jan 6, 2025
Currently, the log of LeaderState#timeUntilCheckQuorumExpires uses streams without a terminal operator, resulting in output like java.util.stream.ReferencePipeline$3@39660237.
This PR aims to fix this issue and improve the log message.

Reviewers: Luke Chen <showuon@gmail.com>
cmccabe pushed a commit that referenced this pull request Feb 4, 2025
Currently, the log of LeaderState#timeUntilCheckQuorumExpires uses streams without a terminal operator, resulting in output like java.util.stream.ReferencePipeline$3@39660237.
This PR aims to fix this issue and improve the log message.

Reviewers: Luke Chen <showuon@gmail.com>
manoj-mathivanan pushed a commit to manoj-mathivanan/kafka that referenced this pull request Feb 19, 2025
Currently, the log of LeaderState#timeUntilCheckQuorumExpires uses streams without a terminal operator, resulting in output like java.util.stream.ReferencePipeline$3@39660237.
This PR aims to fix this issue and improve the log message.

Reviewers: Luke Chen <showuon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants