Skip to content

Conversation

@awaelchli
Copy link
Contributor

What does this PR do?

mv tests/accelerators/legacy/* tests/accelerators/

Follow up on #5743

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Check that target branch and milestone match!

Did you have fun?

Make sure you had fun coding 🙃

@awaelchli awaelchli added ci Continuous Integration refactor labels Feb 12, 2021
@pep8speaks
Copy link

pep8speaks commented Feb 12, 2021

Hello @awaelchli! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-02-13 19:44:54 UTC

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #5948 (fd43953) into master (0345fcf) will decrease coverage by 40%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           master   #5948     +/-   ##
========================================
- Coverage      84%     44%    -40%     
========================================
  Files         184     184             
  Lines       13307   13127    -180     
========================================
- Hits        11138    5765   -5373     
- Misses       2169    7362   +5193     

@awaelchli awaelchli marked this pull request as ready for review February 13, 2021 00:13
@awaelchli awaelchli added the ready PRs ready to be merged label Feb 13, 2021
@Borda Borda added this to the 1.2 milestone Feb 13, 2021
@awaelchli awaelchli enabled auto-merge (squash) February 13, 2021 12:12
@awaelchli awaelchli merged commit a3d4e7c into master Feb 14, 2021
@awaelchli awaelchli deleted the refactor/legacy-cleanup branch February 14, 2021 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration ready PRs ready to be merged refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants