Skip to content

fixed default sampler #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2020
Merged

fixed default sampler #1425

merged 1 commit into from
Apr 9, 2020

Conversation

@williamFalcon
Copy link
Contributor

@williamFalcon williamFalcon commented Apr 9, 2020

Fixes #1422

@mergify mergify bot requested a review from a team April 9, 2020 12:43
Borda
Borda approved these changes Apr 9, 2020
View reviewed changes
Copy link
Collaborator

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Borda Borda added the bug Something isn't working label Apr 9, 2020
@Borda Borda added this to the 0.7.3 milestone Apr 9, 2020
@williamFalcon williamFalcon merged commit 21a1972 into master Apr 9, 2020
@williamFalcon williamFalcon deleted the sampler branch April 9, 2020 16:42
@Borda Borda modified the milestones: 0.7.4, 0.7.3 Apr 10, 2020
@s-rog s-rog mentioned this pull request Apr 16, 2020
Closed
@tullie tullie mentioned this pull request Apr 17, 2020
Merged
5 tasks
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Jun 7, 2020
@williamFalcon @tullie
fixed default sampler (Lightning-AI#1425)
b0071df
@Borda Borda modified the milestones: 0.7.3, v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

pl:0.7.x

Development

Successfully merging this pull request may close these issues.

Not auto add DistributedSampler for DDP training

2 participants

@williamFalcon @Borda