Skip to content

Fix fast_dev_run running validation twice #1365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 3, 2020
Merged

Fix fast_dev_run running validation twice #1365

merged 1 commit into from
Apr 3, 2020

Conversation

@tullie
Copy link
Contributor

@tullie tullie commented Apr 3, 2020

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • [X ] Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

At the moment, when using fast_dev_run, the validation step is run twice. This is because validation_sanity_check is set to 1 so the sanity check is run on validation and then later it's run again because fast_dev_run is run again.

@williamFalcon williamFalcon merged commit 38e89dd into Lightning-AI:master Apr 3, 2020
@Borda Borda added the bug Something isn't working label Apr 3, 2020
@Borda Borda added this to the 0.7.2 milestone Apr 3, 2020
alexeykarnachev pushed a commit to alexeykarnachev/pytorch-lightning that referenced this pull request Apr 4, 2020
@tullie
Fix fast_dev_run running validation twice (Lightning-AI#1365)
45708d4
@Borda
Copy link
Collaborator

Borda commented Apr 4, 2020 •
edited
Loading

@tullie pls add note to changelog, well fixed in #1380

@Borda Borda mentioned this pull request Apr 4, 2020
Merged
tullie added a commit to tullie/pytorch-lightning that referenced this pull request Jun 7, 2020
@tullie
Fix fast_dev_run running validation twice (Lightning-AI#1365)
7ee1726
@Borda Borda modified the milestones: v0.7., v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

pl:0.7.x

Development

Successfully merging this pull request may close these issues.

3 participants

@tullie @Borda @williamFalcon