-
Notifications
You must be signed in to change notification settings - Fork 510
[Metrics][Docker] Add link to Docker available keys #4952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics][Docker] Add link to Docker available keys #4952
Conversation
🌐 Coverage report
|
| @@ -1,4 +1,9 @@ | |||
| # newer versions go on top | |||
| - version: "2.4.1" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As it is an enhancement it is better to go to next minor versions 2.5.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's just a link to docs in the UI. I am not sure it is worth adding a major version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left it as 2.4.1 because it is something minimal, like @gsantoro said. Should I change it anyway? @MichaelKatsoulis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok leave it as it is.
| name: docker | ||
| title: Docker | ||
| version: 2.4.0 | ||
| version: 2.4.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| version: 2.4.1 | |
| version: 2.5.0 |
|
Package docker - 2.4.1 containing this change is available at https://epr.elastic.co/search?package=docker |
What does this PR do?
This PR adds a new line to the conditions form of the Docker package, linking to the available keys.
Checklist
changelog.ymlfile.Screenshots