Skip to content

Conversation

@constanca-m
Copy link
Contributor

@constanca-m constanca-m commented Jan 9, 2023

What does this PR do?

This PR adds a new line to the conditions form of the Docker package, linking to the available keys.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Screenshots

image

@constanca-m constanca-m added the enhancement New feature or request label Jan 9, 2023
@constanca-m constanca-m requested a review from gizas January 9, 2023 16:13
@constanca-m constanca-m requested a review from a team as a code owner January 9, 2023 16:13
@constanca-m constanca-m requested a review from devamanv January 9, 2023 16:13
@constanca-m constanca-m self-assigned this Jan 9, 2023
@elasticmachine
Copy link

elasticmachine commented Jan 9, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-01-09T16:14:34.030+0000

  • Duration: 19 min 1 sec

Test stats 🧪

Test Results
Failed 0
Passed 38
Skipped 0
Total 38

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (0/0) 💚
Files 100.0% (0/0) 💚 2.044
Classes 100.0% (0/0) 💚 2.044
Methods 96.667% (29/30) 👍 5.686
Lines 100.0% (0/0) 💚 8.457
Conditionals 100.0% (0/0) 💚

@@ -1,4 +1,9 @@
# newer versions go on top
- version: "2.4.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it is an enhancement it is better to go to next minor versions 2.5.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's just a link to docs in the UI. I am not sure it is worth adding a major version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left it as 2.4.1 because it is something minimal, like @gsantoro said. Should I change it anyway? @MichaelKatsoulis

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok leave it as it is.

name: docker
title: Docker
version: 2.4.0
version: 2.4.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version: 2.4.1
version: 2.5.0

@constanca-m constanca-m merged commit 409d56d into elastic:main Jan 13, 2023
@elasticmachine
Copy link

Package docker - 2.4.1 containing this change is available at https://epr.elastic.co/search?package=docker

@constanca-m constanca-m deleted the update-docker-description branch January 30, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants