Skip to content

Conversation

@abbrowne126
Copy link
Collaborator

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1545 🦕

@abbrowne126 abbrowne126 requested review from a team as code owners October 28, 2025 14:47
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: pubsub Issues related to the googleapis/python-pubsub API. labels Oct 28, 2025
@abbrowne126
Copy link
Collaborator Author

abbrowne126 commented Oct 28, 2025

For some context, this PR in python API core caused several build failures (example). It's a warning but we error on warnings.

The python language team is going to handle language upgrades on this repo, and separately I believe this is intended for end users to see.

@abbrowne126 abbrowne126 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 28, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 28, 2025
@abbrowne126 abbrowne126 enabled auto-merge (squash) October 28, 2025 17:45
@abbrowne126 abbrowne126 merged commit 8e28dea into main Oct 28, 2025
30 checks passed
@abbrowne126 abbrowne126 deleted the fix-future-warning branch October 28, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The build failed

4 participants