Skip to content

feat: debug logs #1460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Oct 6, 2025
Merged

feat: debug logs #1460

merged 39 commits into from
Oct 6, 2025
+170 −37

Conversation

@abbrowne126
Copy link
Collaborator

@abbrowne126 abbrowne126 commented Sep 29, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1459 🦕

@abbrowne126 abbrowne126 requested review from a team as code owners September 29, 2025 22:10
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsub Issues related to the googleapis/python-pubsub API. labels Sep 29, 2025
@abbrowne126 abbrowne126 marked this pull request as draft September 29, 2025 22:11
@abbrowne126 abbrowne126 added the owlbot:ignore instruct owl-bot to ignore a PR label Sep 30, 2025
@abbrowne126 abbrowne126 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2025
@abbrowne126 abbrowne126 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2025
@abbrowne126 abbrowne126 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2025
@abbrowne126 abbrowne126 marked this pull request as ready for review October 2, 2025 18:29
@abbrowne126 abbrowne126 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 2, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 2, 2025
@abbrowne126 abbrowne126 enabled auto-merge (squash) October 3, 2025 05:08
@abbrowne126 abbrowne126 disabled auto-merge October 3, 2025 05:08
@abbrowne126 abbrowne126 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 3, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 3, 2025
feywind
feywind reviewed Oct 3, 2025
View reviewed changes
Copy link

@feywind feywind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I realize I'm probably too early ^^; but it's looking good so far!

@abbrowne126
Copy link
Collaborator Author

abbrowne126 commented Oct 3, 2025

Sorry, I realize I'm probably too early ^^; but it's looking good so far!

Yes sorry, I'll mark as draft again until ready

@abbrowne126 abbrowne126 requested a review from a team as a code owner October 3, 2025 22:12
@abbrowne126 abbrowne126 requested a review from gericdong October 3, 2025 22:12
@abbrowne126 abbrowne126 enabled auto-merge (squash) October 4, 2025 15:35
@abbrowne126 abbrowne126 mentioned this pull request Oct 6, 2025
Open
michaelpri10
michaelpri10 reviewed Oct 6, 2025
View reviewed changes
google/cloud/pubsub_v1/subscriber/message.py
will be thrown.
"""
_ACK_NACK_LOGGER.debug(
"Called ack for message (id=%s, ack_id=%s, ordering_key=%s, exactly_once=True)",
Copy link
Contributor

@michaelpri10 michaelpri10 Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could users still use the ack_with_response interface when EOD is disabled? If so, it would be worth setting exactly_once=self.exactly_once_enabled

@abbrowne126 abbrowne126 merged commit b5d4a45 into main Oct 6, 2025
29 checks passed
@abbrowne126 abbrowne126 deleted the add-debug-logs branch October 6, 2025 15:56
@release-please release-please bot mentioned this pull request Oct 6, 2025
Merged
This was referenced Oct 15, 2025
Closed
Closed
Closed
@ohmayr ohmayr mentioned this pull request Oct 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@feywind feywind feywind left review comments

@michaelpri10 michaelpri10 michaelpri10 approved these changes

@gericdong gericdong Awaiting requested review from gericdong gericdong was automatically assigned from googleapis/python-samples-reviewers

Assignees

No one assigned

Labels

api: pubsub Issues related to the googleapis/python-pubsub API. owlbot:ignore instruct owl-bot to ignore a PR size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Debug Logs to the Client Library

5 participants

@abbrowne126 @michaelpri10 @feywind @yoshi-kokoro