-
Notifications
You must be signed in to change notification settings - Fork 61
fix: refactor channel refresh #1174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkevinzheng
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: bigtable
Issues related to the googleapis/python-bigtable API.
size: l
Pull request size is large.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python-bigtable performs pre-emptive refresh of its grpc channel. This means it has a background task to automatically cycle out the grpc channel with a new pre-warmed one every ~45 mins, to avoid latency spikes when the channel eventually expires
The current implementation has issues:
To fix this, this PR adds a new
SwappableChannelclass, that wraps a real grpc channel, but provides methods to swap out the channel internally. This allows the channel refrence used by the gapic layer to remain constant, and leads to less abstraction leakage (issue 2/3). The ReplaceableChannel can also store the arguments used to init the channel, and re-use the same arguments when creating new ones (issue 1)I performed some benchmarks, and didn't see a performance regression from this change
Fixes #1094