fix: respect useAuthWithCustomEndpoint flag for resumable uploads #2637
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes resumable uploads to respect the
useAuthWithCustomEndpointconfiguration flag when using custom API endpoints.Problem
Currently, resumable uploads automatically bypass authentication for any non-googleapis.com domain, even when
useAuthWithCustomEndpoint: trueis explicitly set. This prevents using authenticated proxies or custom storage endpoints with resumable uploads.Solution
useAuthWithCustomEndpointflag through to resumable upload configurationuseAuthWithCustomEndpointproperty to Service class for proper type-safe accessChanges Made
1.
src/nodejs-common/service.tsuseAuthWithCustomEndpoint?: booleantoServiceConfiginterfaceuseAuthWithCustomEndpoint?: booleanproperty toServiceclass2.
src/file.tsuseAuthWithCustomEndpointfrom Storage to resumable upload config3.
src/resumable-upload.tsuseAuthWithCustomEndpoint?: booleantoUploadConfiginterface4.
test/resumable-upload.tsTesting
Use Case
This fix is needed for:
Backward Compatibility
✅ Fully maintained - when
useAuthWithCustomEndpointis undefined, the behavior remains unchanged (bypasses auth for custom endpoints)