fix(auth): fix JS interop lints (#17802)

* firebase_auth: fix JS interop lints

* oops

* more cleanup

* fix gemini hint

Author: kevmoo

packages/firebase_auth/firebase_auth_web/lib/src/interop/auth.dart

@@ -23,9 +23,9 @@ Auth getAuthInstance(App app) {
   // Default persistence can be seen here
   // https://github.com/firebase/firebase-js-sdk/blob/main/packages/auth/src/platform_browser/index.ts#L47
   final List<JSAny?> persistences = [
-    auth_interop.indexedDBLocalPersistence as JSAny,
-    auth_interop.browserLocalPersistence as JSAny,
-    auth_interop.browserSessionPersistence as JSAny,
+    auth_interop.indexedDBLocalPersistence,
+    auth_interop.browserLocalPersistence,
+    auth_interop.browserSessionPersistence,
   ];
   return Auth.getInstance(
     auth_interop.initializeAuth(
@@ -128,15 +128,16 @@ class User extends UserInfo<auth_interop.UserJsImpl> {
   Future<String> getIdToken([bool forceRefresh = false]) => jsObject
       .getIdToken(forceRefresh.toJS)
       .toDart
-      .then((value) => (value! as JSString).toDart);
+      .then((value) => value.toDart);
 
   /// Links the user account with the given credentials, and returns any
   /// available additional user information, such as user name.
   Future<UserCredential> linkWithCredential(
           auth_interop.OAuthCredential? credential) =>
-      auth_interop.linkWithCredential(jsObject, credential).toDart.then(
-          (value) => UserCredential.fromJsObject(
-              value! as auth_interop.UserCredentialJsImpl));
+      auth_interop
+          .linkWithCredential(jsObject, credential)
+          .toDart
+          .then(UserCredential.fromJsObject);
 
   /// Links the user account with the given [phoneNumber] in E.164 format
   /// (e.g. +16505550101) and [applicationVerifier].
@@ -146,17 +147,15 @@ class User extends UserInfo<auth_interop.UserJsImpl> {
           .linkWithPhoneNumber(
               jsObject, phoneNumber.toJS, applicationVerifier.jsObject)
           .toDart
-          .then((value) => ConfirmationResult.fromJsObject(
-              value! as auth_interop.ConfirmationResultJsImpl));
+          .then(ConfirmationResult.fromJsObject);
 
   /// Links the authenticated [provider] to the user account using
   /// a pop-up based OAuth flow.
   /// It returns the [UserCredential] information if linking is successful.
   Future<UserCredential> linkWithPopup(AuthProvider provider) => auth_interop
       .linkWithPopup(jsObject, provider.jsObject)
       .toDart
-      .then((value) => UserCredential.fromJsObject(
-          value! as auth_interop.UserCredentialJsImpl));
+      .then(UserCredential.fromJsObject);
 
   /// Links the authenticated [provider] to the user account using
   /// a full-page redirect flow.
@@ -170,8 +169,7 @@ class User extends UserInfo<auth_interop.UserJsImpl> {
       auth_interop
           .reauthenticateWithCredential(jsObject, credential)
           .toDart
-          .then((value) => UserCredential.fromJsObject(
-              value! as auth_interop.UserCredentialJsImpl));
+          .then(UserCredential.fromJsObject);
 
   /// Re-authenticates a user using a fresh credential.
   /// Use before operations such as [updatePassword] that require tokens
@@ -184,8 +182,7 @@ class User extends UserInfo<auth_interop.UserJsImpl> {
           .reauthenticateWithPhoneNumber(
               jsObject, phoneNumber.toJS, applicationVerifier.jsObject)
           .toDart
-          .then((value) => ConfirmationResult.fromJsObject(
-              value! as auth_interop.ConfirmationResultJsImpl));
+          .then(ConfirmationResult.fromJsObject);
 
   /// Reauthenticates a user with the specified provider using
   /// a pop-up based OAuth flow.
@@ -194,8 +191,7 @@ class User extends UserInfo<auth_interop.UserJsImpl> {
       auth_interop
           .reauthenticateWithPopup(jsObject, provider.jsObject)
           .toDart
-          .then((value) => UserCredential.fromJsObject(
-              value! as auth_interop.UserCredentialJsImpl));
+          .then(UserCredential.fromJsObject);
 
   /// Reauthenticates a user with the specified OAuth [provider] using
   /// a full-page redirect flow.
@@ -240,7 +236,7 @@ class User extends UserInfo<auth_interop.UserJsImpl> {
   Future<User> unlink(String providerId) => auth_interop
       .unlink(jsObject, providerId.toJS)
       .toDart
-      .then((user) => User.getInstance(user! as auth_interop.UserJsImpl)!);
+      .then((user) => User.getInstance(user)!);
 
   /// Updates the user's e-mail address to [newEmail].
   Future<void> updateEmail(String newEmail) =>
@@ -267,8 +263,7 @@ class User extends UserInfo<auth_interop.UserJsImpl> {
         ? jsObject.getIdTokenResult()
         : jsObject.getIdTokenResult(forceRefresh.toJS);
 
-    return promise.toDart.then((value) =>
-        IdTokenResult._fromJsObject(value! as auth_interop.IdTokenResultImpl));
+    return promise.toDart.then(IdTokenResult._fromJsObject);
   }
 
   /// Returns a JSON-serializable representation of this object.
@@ -535,10 +530,7 @@ class Auth extends JsObjectWrapper<auth_interop.AuthJsImpl> {
   /// out-of-band mechanism.
   /// It returns [ActionCodeInfo], metadata about the code.
   Future<auth_interop.ActionCodeInfo> checkActionCode(String code) =>
-      auth_interop
-          .checkActionCode(jsObject, code.toJS)
-          .toDart
-          .then((value) => value! as auth_interop.ActionCodeInfo);
+      auth_interop.checkActionCode(jsObject, code.toJS).toDart;
 
   /// Completes password reset process with a [code] and a [newPassword].
   Future confirmPasswordReset(String code, String newPassword) => auth_interop
@@ -565,7 +557,7 @@ class Auth extends JsObjectWrapper<auth_interop.AuthJsImpl> {
         .createUserWithEmailAndPassword(jsObject, email.toJS, password.toJS)
         .toDart;
 
-    return UserCredential.fromJsObject(u! as auth_interop.UserCredentialJsImpl);
+    return UserCredential.fromJsObject(u);
   }
 
   /// Gets the list of possible sign in methods for the given email address.
@@ -587,13 +579,9 @@ class Auth extends JsObjectWrapper<auth_interop.AuthJsImpl> {
   /// if sign is unsuccessful.
   /// The [UserCredential] with a null [User] is returned if no redirect
   /// operation was called.
-  Future<UserCredential?> getRedirectResult() => auth_interop
-      .getRedirectResult(jsObject)
-      .toDart
-      .then((value) => value == null
-          ? null
-          : UserCredential.fromJsObject(
-              value as auth_interop.UserCredentialJsImpl));
+  Future<UserCredential?> getRedirectResult() =>
+      auth_interop.getRedirectResult(jsObject).toDart.then(
+          (value) => value == null ? null : UserCredential.fromJsObject(value));
 
   /// Sends a sign-in email link to the user with the specified email.
   ///
@@ -676,9 +664,10 @@ class Auth extends JsObjectWrapper<auth_interop.AuthJsImpl> {
   /// available additional user information, such as user name.
   Future<UserCredential> signInWithCredential(
           auth_interop.OAuthCredential credential) =>
-      auth_interop.signInWithCredential(jsObject, credential).toDart.then(
-          (value) => UserCredential.fromJsObject(
-              value! as auth_interop.UserCredentialJsImpl));
+      auth_interop
+          .signInWithCredential(jsObject, credential)
+          .toDart
+          .then(UserCredential.fromJsObject);
 
   /// Asynchronously signs in as an anonymous user.
   //
@@ -688,8 +677,7 @@ class Auth extends JsObjectWrapper<auth_interop.AuthJsImpl> {
   Future<UserCredential> signInAnonymously() => auth_interop
       .signInAnonymously(jsObject)
       .toDart
-      .then((value) => UserCredential.fromJsObject(
-          value! as auth_interop.UserCredentialJsImpl));
+      .then(UserCredential.fromJsObject);
 
   /// Asynchronously signs in using a custom token.
   ///
@@ -701,8 +689,7 @@ class Auth extends JsObjectWrapper<auth_interop.AuthJsImpl> {
   Future<UserCredential> signInWithCustomToken(String token) => auth_interop
       .signInWithCustomToken(jsObject, token.toJS)
       .toDart
-      .then((value) => UserCredential.fromJsObject(
-          value! as auth_interop.UserCredentialJsImpl));
+      .then(UserCredential.fromJsObject);
 
   /// Signs in a user asynchronously using a custom [token] and returns any
   /// additional user info data or credentials.
@@ -731,16 +718,14 @@ class Auth extends JsObjectWrapper<auth_interop.AuthJsImpl> {
       auth_interop
           .signInWithEmailAndPassword(jsObject, email.toJS, password.toJS)
           .toDart
-          .then((value) => UserCredential.fromJsObject(
-              value! as auth_interop.UserCredentialJsImpl));
+          .then(UserCredential.fromJsObject);
 
   /// Signs in using [email] and [emailLink] link.
   Future<UserCredential> signInWithEmailLink(String email, String emailLink) =>
       auth_interop
           .signInWithEmailLink(jsObject, email.toJS, emailLink.toJS)
           .toDart
-          .then((value) => UserCredential.fromJsObject(
-              value! as auth_interop.UserCredentialJsImpl));
+          .then(UserCredential.fromJsObject);
 
   /// Asynchronously signs in using a phone number in E.164 format
   /// (e.g. +16505550101).
@@ -765,7 +750,7 @@ class Auth extends JsObjectWrapper<auth_interop.AuthJsImpl> {
         .toDart;
 
     return ConfirmationResult.fromJsObject(
-      result! as auth_interop.ConfirmationResultJsImpl,
+      result,
     );
   }
 
@@ -775,8 +760,7 @@ class Auth extends JsObjectWrapper<auth_interop.AuthJsImpl> {
   Future<UserCredential> signInWithPopup(AuthProvider provider) => auth_interop
       .signInWithPopup(jsObject, provider.jsObject)
       .toDart
-      .then((value) => UserCredential.fromJsObject(
-          value! as auth_interop.UserCredentialJsImpl));
+      .then(UserCredential.fromJsObject);
 
   /// Signs in using a full-page redirect flow with the given [provider].
   Future signInWithRedirect(AuthProvider provider) =>
@@ -803,7 +787,7 @@ class Auth extends JsObjectWrapper<auth_interop.AuthJsImpl> {
   Future<String> verifyPasswordResetCode(String code) => auth_interop
       .verifyPasswordResetCode(jsObject, code.toJS)
       .toDart
-      .then((value) => (value! as JSString).toDart);
+      .then((value) => value.toDart);
 
   /// Initializes the reCAPTCHA Enterprise client proactively to enhance reCAPTCHA signal collection and
   /// to complete reCAPTCHA-protected flows in a single attempt.
@@ -1216,8 +1200,7 @@ class ConfirmationResult
   Future<UserCredential> confirm(String verificationCode) => jsObject
       .confirm(verificationCode.toJS)
       .toDart
-      .then((value) => UserCredential.fromJsObject(
-          value! as auth_interop.UserCredentialJsImpl));
+      .then(UserCredential.fromJsObject);
 }
 
 /// A structure containing a [User], an [OAuthCredential] and [operationType].