-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[FDC] Add seed data for the initial template #9232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @fredzqm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Data Connect initial template by incorporating a Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds seed data to the Data Connect movie template, which will improve the initial user experience by providing sample data. The changes include adding a seed_data.gql file with GraphQL mutations for movies, metadata, users, and reviews. The initialization logic is updated to handle this new seed data file.
My review has identified a few minor issues:
- The changelog entry has an empty placeholder.
- There are a couple of typos in image URLs within the new seed data file.
Fixing these will improve the quality of the template. Overall, this is a good addition.
Tested the seed data executed successfully against local pglite, against ephemeral database & CSQL in prod.
I used the seed data in web code lab as a starting point and trim down unknown tables and columns.
https://github.com/FirebaseExtended/codelab-dataconnect-web/blob/main/dataconnect/moviedata_insert.gql
Grouped FDC related changelog together. We have a lot going out this week.