Skip to content

Conversation

@fredzqm
Copy link
Contributor

@fredzqm fredzqm commented Oct 1, 2025

Tested the seed data executed successfully against local pglite, against ephemeral database & CSQL in prod.

I used the seed data in web code lab as a starting point and trim down unknown tables and columns.
https://github.com/FirebaseExtended/codelab-dataconnect-web/blob/main/dataconnect/moviedata_insert.gql

Grouped FDC related changelog together. We have a lot going out this week.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fredzqm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Data Connect initial template by incorporating a seed_data.gql file. This file contains GraphQL mutations designed to pre-populate the template with sample data for movies, movie metadata, users, and reviews, making it easier for developers to get started with a functional dataset immediately upon initialization.

Highlights

  • Seed Data Addition: Introduced a new seed_data.gql file to provide initial sample data for the Data Connect movie template, including movies, metadata, users, and reviews.
  • Template Integration: The newly added seed data template is now integrated into the Data Connect initialization process, ensuring new projects start with pre-populated data.
  • Changelog Update: The CHANGELOG.md file has been updated to reflect the addition of seed_data.gql to the initial movie template.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds seed data to the Data Connect movie template, which will improve the initial user experience by providing sample data. The changes include adding a seed_data.gql file with GraphQL mutations for movies, metadata, users, and reviews. The initialization logic is updated to handle this new seed data file.

My review has identified a few minor issues:

  • The changelog entry has an empty placeholder.
  • There are a couple of typos in image URLs within the new seed data file.

Fixing these will improve the quality of the template. Overall, this is a good addition.

@fredzqm fredzqm enabled auto-merge (squash) October 1, 2025 23:58
@fredzqm fredzqm disabled auto-merge October 2, 2025 00:10
@fredzqm fredzqm enabled auto-merge (squash) October 2, 2025 00:14
@fredzqm fredzqm merged commit 537242c into master Oct 2, 2025
48 checks passed
@fredzqm fredzqm deleted the fz/seed_data branch October 2, 2025 00:52
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants