Skip to content

Conversation

@fredzqm
Copy link
Contributor

@fredzqm fredzqm commented Sep 24, 2025

Bug Scenario

While testing the "local onboard flow", I ran into this bug when click the "init" button.

Screenshot 2025-09-23 at 5 32 51 PM

create-vite cmd added additional prompts that made it work poorly for piped stdin when launched from VS Code.

Tested

Screenshot 2025-09-23 at 5 36 20 PM Screenshot 2025-09-23 at 5 37 15 PM Screenshot 2025-09-23 at 5 38 47 PM

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @fredzqm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Firebase Data Connect initialization process by modifying the React application creation to be non-interactive. This change prevents user prompts during the vite create command, which is beneficial for automated setups and consistent deployments, improving the overall developer experience.

Highlights

  • Non-interactive Vite App Creation: The createReactApp function now includes the --no-interactive flag when executing npm create vite@latest. This ensures that the React application setup process does not prompt for user input, streamlining automated or script-driven initialization for Firebase Data Connect.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request attempts to make the Vite app creation non-interactive by adding the --no-interactive flag. However, this flag is not recognized by create-vite and will cause an error. My review includes a critical fix to correctly disable interactivity by specifying a complete template name, which I believe should be react-ts to align with the use of TypeScript elsewhere in the project.

@fredzqm fredzqm changed the title [FDC init] Add --no-interactive to the cmd [FDC init] Fix a minor bug React template when launched from VS Code Sep 24, 2025
@fredzqm fredzqm changed the title [FDC init] Fix a minor bug React template when launched from VS Code [FDC init] Fix React template creation when launched from VS Code Sep 24, 2025
Copy link
Contributor

@maneesht maneesht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Fred!

@fredzqm fredzqm merged commit 1823d51 into master Sep 24, 2025
48 checks passed
@fredzqm fredzqm deleted the fz/fdc-react-no-interactive branch September 24, 2025 16:50
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Sep 24, 2025
annajowang pushed a commit that referenced this pull request Sep 26, 2025
jrothfeder pushed a commit that referenced this pull request Oct 2, 2025
)

* Add --no-interactive to the cmd

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants