Skip to content

Conversation

@fredzqm
Copy link
Contributor

@fredzqm fredzqm commented Sep 8, 2025

A few couple of improvements.

  • Rename dataconnect_info to dataconnect_list_services to improve discovabilities. info made it sounds like a docsite summary.
  • When MCP firebase_init tool is called with an existing dataconnect service, it should download existing sources.
  • Enable API in init actuate in case MCP tool was called from a fresh new project.
  • Catch error from sdk generate cmd.
  • [refactor] Extract a templateServiceInfo

New Service Onboard w/ Gemini CLI

https://screencast.googleplex.com/cast/NTU1MjgyMTMyMjY0NTUwNHw3NTI2YzYxNC0yOQ

Existing Service w/ Gemini CLI

https://screencast.googleplex.com/cast/NTQwMzAyMTQ1MzI5NTYxNnw4ZjZhM2UxZC1hMA

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @fredzqm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refines the firebase init dataconnect command's behavior, particularly when dealing with projects that already have existing Data Connect services. The primary goal is to provide a more seamless and intelligent initialization experience, allowing the CLI to recognize and download existing service configurations, which is crucial for integration with internal tools like MCP.

Highlights

  • Refactored Data Connect Initialization Constants: Consolidated multiple default constants (emptyConnector, defaultConnector, defaultSchema) into a single, more comprehensive defaultServiceInfo object for better organization and clarity.
  • Enhanced Existing Service Handling in firebase init dataconnect: The initialization flow now intelligently detects if a Data Connect service already exists for a given project and, if so, downloads its configuration from the backend instead of creating a new one or relying solely on local templates. This is particularly beneficial for tools like MCP.
  • Streamlined Service Selection Logic: The internal logic for choosing an existing Data Connect service has been simplified by removing an unnecessary intermediate interface (serviceAndSchema) and directly working with Service objects, improving code readability and maintainability.
  • Renamed and Refocused MCP Tool: The info tool within the MCP (Managed Control Plane) for Data Connect has been renamed to list_services and its description updated to more accurately reflect its purpose of listing existing services.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the Data Connect initialization flow to better handle existing services. The key changes include checking for and downloading an existing service early in the process, which simplifies the overall logic and avoids asking the user for redundant information. It also improves performance by deferring schema fetching until after a service is chosen. The code is cleaner and the user experience for setting up an existing service is improved. My review includes one suggestion to improve the clarity of local directory naming for downloaded connectors.

@fredzqm fredzqm requested a review from joehan September 8, 2025 16:12
@fredzqm fredzqm changed the title [FDC] Improve MCP init flow to setup an existing service [FDC] Improve MCP init flow of existing FDC service Sep 8, 2025
@fredzqm
Copy link
Contributor Author

fredzqm commented Sep 8, 2025

[P2 no deadline]

@joehan I got some more MCP improvements in the onboard flow. Got two e2e demos recorded.

Let me know what you think~

@fredzqm fredzqm enabled auto-merge (squash) September 9, 2025 23:39
@fredzqm fredzqm merged commit 821de06 into master Sep 9, 2025
48 checks passed
@fredzqm fredzqm deleted the fz/mcp-existing branch September 9, 2025 23:48
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Sep 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants