Skip to content

Conversation

@visumickey
Copy link
Contributor

Addresses feature request #8676

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @visumickey, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces new capabilities to the Firebase Crashlytics tooling by adding functionalities to fetch detailed information about specific Crashlytics issues and retrieve sample crash data. This enhancement allows users to programmatically access more granular Crashlytics data, addressing a specific feature request. The changes involve adding new API client utilities and exposing them as managed cloud platform tools, thereby expanding the scope of automated Crashlytics management.

Highlights

  • New Crashlytics API Utilities: Two new core utility functions, fetchIssueDetails and getSampleCrash, have been added to interact with the Crashlytics API. These functions allow retrieval of specific issue details and sample crash data for a given issue ID.
  • New MCP Tools for Crashlytics: Corresponding MCP (Managed Cloud Platform) tools, fetch_issue_details and get_sample_crash, have been introduced. These tools expose the new utility functions, making them accessible for automated or programmatic use within the Firebase ecosystem.
  • Tool Integration: The new tools have been integrated into the existing Crashlytics tool index, ensuring they are discoverable and usable alongside other Crashlytics-related functionalities.
  • Minor Tool Enhancement: A minor enhancement was made to the list_top_issues tool, setting a default value of 10 for the issue_count parameter, improving its usability when the count is not explicitly specified.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new tools for fetching Crashlytics issue details and sample crashes. The changes include new API client functions and their corresponding tool definitions for the MCP. My review focuses on improving maintainability by reducing code duplication and ensuring correctness by aligning schema definitions with implementation logic. I've also pointed out a minor error message inaccuracy.

Copy link
Member

@raymondlam raymondlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use get_issue_details instead of fetch_issue_details to align with general API conventions.

Nit, we could also use get_crash_sample instead of get_sample_crash since the crash is the resource.

Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM - probably worth testing this with some agents to see if the strategy you used for the descriptions works like we hope

@joehan
Copy link
Contributor

joehan commented Aug 19, 2025

Also add a Changelog please

@visumickey visumickey force-pushed the mcp_crashlytics_lookup_issue branch from c2a2aea to 4d6538d Compare August 19, 2025 20:00
@visumickey visumickey merged commit 49bd4ef into master Aug 19, 2025
48 checks passed
@visumickey visumickey deleted the mcp_crashlytics_lookup_issue branch August 19, 2025 21:45
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants