Skip to content

Conversation

@tammam-g
Copy link
Contributor

@tammam-g tammam-g commented Jun 4, 2025

This PR adds emulator support in firebase storage tools. It seems like the only relevant storage tool is get_object_download_url which I confirmed works but uploading a file through the emulator UI interfance and confirming the returned URL downloads the file I uploaded.

Should be reviewed after #8706

image

@tammam-g tammam-g removed the request for review from fredzqm June 4, 2025 20:08
@codecov-commenter
Copy link

codecov-commenter commented Jun 4, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 52.03%. Comparing base (7f80f9f) to head (2a2709f).
Report is 27 commits behind head on master.

Files with missing lines Patch % Lines
src/gcp/storage.ts 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8707      +/-   ##
==========================================
+ Coverage   51.09%   52.03%   +0.93%     
==========================================
  Files         427      407      -20     
  Lines       30930    30263     -667     
  Branches     6350     6266      -84     
==========================================
- Hits        15803    15746      -57     
+ Misses      13715    13100     -615     
- Partials     1412     1417       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tammam-g tammam-g enabled auto-merge (squash) June 4, 2025 22:05
@tammam-g tammam-g merged commit bf7fdea into master Jun 4, 2025
48 of 50 checks passed
@tammam-g tammam-g deleted the tammam/storage-mcp-emulator branch June 4, 2025 22:15
@github-project-automation github-project-automation bot moved this from Approved [PR] to Done in [Cloud] Extensions + Functions Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants