Skip to content

Conversation

@hlshen
Copy link
Contributor

@hlshen hlshen commented Aug 23, 2024

Do not release until emulator updates endpoints

@hlshen hlshen requested a review from joehan August 23, 2024 17:47
@hlshen hlshen marked this pull request as draft August 23, 2024 19:33
Copy link
Contributor

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests in dataconnect/client.spec.ts are failing - looks like you just need to update the references to v1alpha in there as well.

@hlshen hlshen requested a review from joehan September 3, 2024 16:52
@hlshen hlshen marked this pull request as ready for review September 3, 2024 16:52
@hlshen hlshen merged commit c222f52 into master Sep 18, 2024
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants