-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Make firebase init dataconnect not wait for Cloud SQL instances provision
#7275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
firebase init dataconnect not wait for Cloud SQL instances provision
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7275 +/- ##
==========================================
- Coverage 54.06% 54.03% -0.04%
==========================================
Files 386 386
Lines 26137 26156 +19
Branches 5370 5378 +8
==========================================
+ Hits 14131 14133 +2
- Misses 10742 10759 +17
Partials 1264 1264 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after changes
Ran through the onboard flow today.
The existing output made me feel compelled to sit there and wait for
firebase initto finish.Though customers can totally start coding right away.
firebase init dataconnectnot waiting for Cloud SQL instance.state=failedcloud sql state. Currently, we show those as succeed, but it's actually completely busted and unusable.Scenarios Tested
firebase inittakes over a "fresh from console" service.It spits out a link to monitor Cloud SQL provision instead of a forever long spinner that drives developer away.
Then, rerun
firebase initwhile the Cloud SQL instance is being created.Then attempt

firebase deploywhile the Cloud SQL instance is being created.firebase initwhen Cloud SQL instance is in a failed state (ran into this while deleting and recreating the instance)