Skip to content

Conversation

@inlined
Copy link
Member

@inlined inlined commented Jan 9, 2024

Fixes #6666

I've deployed a test application and verified that Python 3.12.1 was running. IDK where the integration tests are though, so I'll let the regular folks own quality control.

@inlined inlined requested a review from blidd-google January 9, 2024 23:40
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 54.33%. Comparing base (f584799) to head (a2a4809).
Report is 920 commits behind head on master.

Files with missing lines Patch % Lines
src/deploy/functions/runtimes/python/index.ts 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6679      +/-   ##
==========================================
- Coverage   54.33%   54.33%   -0.01%     
==========================================
  Files         350      350              
  Lines       24286    24288       +2     
  Branches     5020     5021       +1     
==========================================
  Hits        13196    13196              
- Misses       9885     9886       +1     
- Partials     1205     1206       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dcgudeman
Copy link

dcgudeman commented Jan 25, 2024

So what's the status of the PR? Why hasn't it been merged yet? @blidd-google

@johndunderhill
Copy link

Python 3.12 is the 'recommend' runtime for Python on Cloud Run. v2 cloud functions run on Cloud Run.

https://cloud.google.com/functions/docs/concepts/python-runtime

FWIW, I hacked this PR into firebase-tools and saved it using a pnpm patch file. I tested deployment and execution, and everything worked fine. So far we've tested only with very simple functions.

There could of course be broader issues, such as compatibility with the Firebase Python libraries. It would be nice if someone with more knowledge could review, advise and/or merge this. We are currently developing on Python 3.12.

@dcgudeman
Copy link

How is this PR still unreviewed?

@blidd-google blidd-google enabled auto-merge (squash) February 12, 2024 21:26
@blidd-google blidd-google merged commit d1624ff into master Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support for python 3.12 runtime for firebase functions

5 participants