Provision App Hosting compute service account during init flow (#8580)

* provision compute SA in fah init flow

Author: blidd-google

CHANGELOG.md

@@ -5,3 +5,4 @@
 - Add GCP API client functions to support App Hosting deploy from source feature. (#8545)
 - Changed firebase init template for functions to pin runtime version on init. (#8553)
 - Fix an issue where updating a Cloud Function that retires would add incorrect fields to the updateMask. (#8560)
+- Provision App Hosting compute service account during init flow. (#8580)

src/apphosting/backend.ts

@@ -76,14 +76,7 @@ export async function doSetup(
   webAppName: string | null,
   serviceAccount: string | null,
 ): Promise<void> {
-  await Promise.all([
-    ensure(projectId, developerConnectOrigin(), "apphosting", true),
-    ensure(projectId, cloudbuildOrigin(), "apphosting", true),
-    ensure(projectId, secretManagerOrigin(), "apphosting", true),
-    ensure(projectId, cloudRunApiOrigin(), "apphosting", true),
-    ensure(projectId, artifactRegistryDomain(), "apphosting", true),
-    ensure(projectId, iamOrigin(), "apphosting", true),
-  ]);
+  await ensureRequiredApisEnabled(projectId);
 
   // Hack: Because IAM can take ~45 seconds to propagate, we provision the service account as soon as
   // possible to reduce the likelihood that the subsequent Cloud Build fails. See b/336862200.
@@ -179,6 +172,20 @@ export async function doSetup(
   logSuccess(`Your backend is now deployed at:\n\thttps://${backend.uri}`);
 }
 
+/**
+ * Check that all GCP APIs required for App Hosting are enabled.
+ */
+export async function ensureRequiredApisEnabled(projectId: string): Promise<void> {
+  await Promise.all([
+    ensure(projectId, developerConnectOrigin(), "apphosting", true),
+    ensure(projectId, cloudbuildOrigin(), "apphosting", true),
+    ensure(projectId, secretManagerOrigin(), "apphosting", true),
+    ensure(projectId, cloudRunApiOrigin(), "apphosting", true),
+    ensure(projectId, artifactRegistryDomain(), "apphosting", true),
+    ensure(projectId, iamOrigin(), "apphosting", true),
+  ]);
+}
+
 /**
  * Set up a new App Hosting-type Developer Connect GitRepoLink, optionally with a specific connection ID
  */

src/commands/init.ts

@@ -48,7 +48,7 @@ let choices: {
   },
   {
     value: "apphosting",
-    name: "App Hosting: Configure an apphosting.yaml file for App Hosting",
+    name: "App Hosting: Enable web app deployments with App Hosting",
     checked: false,
     hidden: false,
   },

src/init/features/apphosting.ts

@@ -2,22 +2,25 @@ import * as clc from "colorette";
 import { existsSync } from "fs";
 import * as ora from "ora";
 import * as path from "path";
+import { Setup } from "..";
 import { webApps } from "../../apphosting/app";
 import {
   createBackend,
+  ensureAppHostingComputeServiceAccount,
+  ensureRequiredApisEnabled,
   promptExistingBackend,
   promptLocation,
   promptNewBackendId,
 } from "../../apphosting/backend";
 import { Config } from "../../config";
 import { FirebaseError } from "../../error";
 import { AppHostingSingle } from "../../firebaseConfig";
+import { ensureApiEnabled } from "../../gcp/apphosting";
+import { isBillingEnabled } from "../../gcp/cloudbilling";
+import { input, select } from "../../prompt";
 import { readTemplateSync } from "../../templates";
 import * as utils from "../../utils";
 import { logBullet } from "../../utils";
-import { input, select } from "../../prompt";
-import { Setup } from "..";
-import { isBillingEnabled } from "../../gcp/cloudbilling";
 
 const APPHOSTING_YAML_TEMPLATE = readTemplateSync("init/apphosting/apphosting.yaml");
 
@@ -31,6 +34,19 @@ export async function doSetup(setup: Setup, config: Config): Promise<void> {
       "Firebase App Hosting requires billing to be enabled on your project. Please enable billing by following the steps at https://cloud.google.com/billing/docs/how-to/modify-project",
     );
   }
+  await ensureApiEnabled({ projectId });
+  await ensureRequiredApisEnabled(projectId);
+  try {
+    await ensureAppHostingComputeServiceAccount(projectId, /* serviceAccount= */ "");
+  } catch (err) {
+    if ((err as FirebaseError).status === 400) {
+      utils.logWarning(
+        "Your App Hosting compute service account is still being provisioned. Please try again in a few moments.",
+      );
+    }
+    throw err;
+  }
+
   utils.logBullet(
     "This command links your local project to Firebase App Hosting. You will be able to deploy your web app with `firebase deploy` after setup.",
   );

src/init/index.ts

@@ -31,6 +31,7 @@ export interface SetupInfo {
 
 interface Feature {
   name: string;
+  displayName?: string;
   // OLD WAY: A single setup function to ask questions and actuate the setup.
   doSetup?: (setup: Setup, config: Config, options: Options) => Promise<unknown>;
 
@@ -64,7 +65,7 @@ const featuresList: Feature[] = [
   { name: "remoteconfig", doSetup: features.remoteconfig },
   { name: "hosting:github", doSetup: features.hostingGithub },
   { name: "genkit", doSetup: features.genkit },
-  { name: "apphosting", doSetup: features.apphosting },
+  { name: "apphosting", displayName: "App Hosting", doSetup: features.apphosting },
 ];
 
 const featureMap = new Map(featuresList.map((feature) => [feature.name, feature]));
@@ -73,7 +74,9 @@ export async function init(setup: Setup, config: any, options: any): Promise<any
   const nextFeature = setup.features?.shift();
   if (nextFeature) {
     const f = lookupFeature(nextFeature);
-    logger.info(clc.bold(`\n${clc.white("===")} ${capitalize(nextFeature)} Setup`));
+    logger.info(
+      clc.bold(`\n${clc.white("===")} ${f.displayName || capitalize(nextFeature)} Setup`),
+    );
 
     if (f.doSetup) {
       await f.doSetup(setup, config, options);