Limit the number of unsent reports on disk to prevent disk filling #7619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamvduke
reviewed
Feb 26, 2021
Crashlytics/Crashlytics/Controllers/FIRCLSExistingReportManager.m
Outdated
Show resolved
Hide resolved
Crashlytics/Crashlytics/Controllers/FIRCLSExistingReportManager.m
Outdated
Show resolved
Hide resolved
adamvduke
approved these changes
Mar 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the developer turns automatic collection off, they run the risk of filling up disk space with unsent reports if they never call send/deleteUnsentReports. In addition, having too many unsent reports can cause performance problems when trying to find the newest unsent report.
This change limits the number of unsent reports to 4 to match Android: https://github.com/firebase/firebase-android-sdk/blob/e65f4876ff61b5791986c249b21cb094c37bd29e/firebase-crashlytics/src/main/java/com/google/firebase/crashlytics/internal/settings/SettingsJsonConstants.java#L61