Skip to content

Conversation

@paulb777
Copy link
Member

@paulb777 paulb777 commented Jan 2, 2020

@morganchen12
Copy link
Contributor

Please update the Danger PR autolabeler as well: https://github.com/firebase/firebase-ios-sdk/blob/master/Dangerfile#L90

Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM but one concern I have is a large amount of the files showing up as new instead of moved - only worry being it's not as easy to see a blame of each file.

@paulb777
Copy link
Member Author

paulb777 commented Jan 2, 2020

Thanks for the push. There was an extra copy of those files. Now the diff should be right.

Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better diff, thank you!

@paulb777 paulb777 merged commit b6cd99e into master Jan 3, 2020
@paulb777 paulb777 deleted the pb-storage-reorg branch January 3, 2020 15:22
@firebase firebase locked and limited conversation to collaborators Feb 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants