Do not activate if fetch returns NO_CHANGE #4260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlotteliang
approved these changes
Nov 7, 2019
| /// The latest eTag value stored from the last successful response. | ||
| @property(nonatomic, readwrite, assign) NSString *lastETag; | ||
| /// The timestamp of the last eTag update. | ||
| @property(nonatomic, readwrite, assign) NSTimeInterval lastETagUpdateTime; |
There was a problem hiding this comment.
should we persist this value? cuz what happened before the current app launch.
| DISPATCH_QUEUE_SERIAL); | ||
| _configFetch[i] = OCMPartialMock([[RCNConfigFetch alloc] initWithContent:configContent | ||
| DBManager:_DBManager | ||
| settings:settings |
There was a problem hiding this comment.
is this format right? Maybe run script/style.sh
There was a problem hiding this comment.
This is with style.sh.
paulb777
approved these changes
Nov 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes internal bug: 143622863. We activate only if fetched data has not resulted in a data change. We track this using the last time the ETag was changed (corresponds to a real change to the RC template).
This change also mirrors current android behavior.