Remove the class FIRMessagingRmq2PersistentStore #4045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alling the same functions in FIRMessagingRmq2PersistentStore
charlotteliang
changed the title
charlotteliang
changed the title
charlotteliang
requested review from
maksymmalyhin,
morganchen12 and
paulb777
| #if defined(DEBUG) | ||
| #define FIRMesssaging_MUST_NOT_BE_MAIN_THREAD() \ | ||
| do { \ | ||
| NSAssert(![NSThread isMainThread], @"Must not be executing on the main thread."); \ |
There was a problem hiding this comment.
Though it's debug-only, this assert may trigger false-positives if the main GCD queue is suspended. See http://blog.benjamin-encz.de/post/main-queue-vs-main-thread/
There was a problem hiding this comment.
Removed it for now. Also realize we don't set DEBUG flag anymore so this would be barely used.
morganchen12
approved these changes
Oct 10, 2019
paulb777
approved these changes
Oct 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file FIRMessagingRmqManager is essentially calling the same functions of FIRMessagingRmq2PersistentStore, that becomes an unnecessary class layer.
Merging FIRMessagingRmq2PersistentStore into FIRMessagingRmqManager and remove the file FIRMessagingRmq2PersistentStore.
This is a clean up before fixing the issue: b/142357385
We need to move database operations off main thread and by reducing the unnecessary class layer helps us adding async call in the next PR.
minor: remove removeRmqMessagesWithRmqId: method as it's only used in test.