Skip to content

Bug fix for flaky behaviour when using Map in arrayRemove #12378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 13, 2024
Merged

Bug fix for flaky behaviour when using Map in arrayRemove #12378

merged 4 commits into from
Feb 13, 2024

Conversation

@cherylEnkidu
Copy link
Contributor

@cherylEnkidu cherylEnkidu commented Feb 9, 2024 •
edited
Loading

When user calls arrayRemove on map object, since the key order in mutation is not necessary align with the order in document and the SDK falsely assume for hash map the item is always sorted by keys, sometimes arrayRemove doesn't work.

@firebase firebase deleted a comment from google-oss-bot Feb 9, 2024
@google-oss-bot
Copy link

google-oss-bot commented Feb 9, 2024 •
edited
Loading

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.15% (7b9125a) to 88.15% (513a226) by +0.01%.

    FilenameBase (7b9125a)Merge (513a226)Diff
    ordered_code.cc93.90%94.39%+0.49%
    task.cc93.91%94.78%+0.87%
    value_util.cc95.71%95.64%-0.06%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/CXEYxlBlm1.html

@cherylEnkidu cherylEnkidu requested a review from ehsannas February 9, 2024 20:13
ehsannas
ehsannas reviewed Feb 9, 2024
View reviewed changes
@ehsannas ehsannas assigned cherylEnkidu and unassigned ehsannas Feb 9, 2024
ehsannas
ehsannas approved these changes Feb 12, 2024
View reviewed changes
@ehsannas ehsannas assigned cherylEnkidu and unassigned ehsannas Feb 12, 2024
@cherylEnkidu cherylEnkidu enabled auto-merge (squash) February 13, 2024 15:11
@cherylEnkidu cherylEnkidu merged commit 2c76938 into main Feb 13, 2024
@cherylEnkidu cherylEnkidu deleted the cheryllin/debugSnapShotCache branch February 13, 2024 15:41
@firebase firebase locked and limited conversation to collaborators Mar 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ehsannas ehsannas ehsannas approved these changes

Assignees

@cherylEnkidu cherylEnkidu

Labels

api: firestore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cherylEnkidu @google-oss-bot @ehsannas