Skip to content

Deprecate androidClientID and trackingID #10520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2022
Merged

Deprecate androidClientID and trackingID #10520

merged 1 commit into from
Dec 15, 2022

Conversation

@paulb777
Copy link
Member

@paulb777 paulb777 commented Nov 23, 2022 •
edited
Loading

@google-oss-bot
Copy link

google-oss-bot commented Nov 24, 2022

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.26% (7196035) to 88.25% (96c5b01) by -0.00%.

    FilenameBase (7196035)Merge (96c5b01)Diff
    leveldb_key.cc98.63%98.43%-0.20%
    task.cc94.78%93.91%-0.87%
    write_stream.cc91.55%94.37%+2.82%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/HxGNXxhXAa.html

@paulb777
Copy link
Member Author

paulb777 commented Nov 28, 2022

Will merge on API review approval

@paulb777 paulb777 merged commit 1fa2b4f into master Dec 15, 2022
@paulb777 paulb777 deleted the pb-firoptions-deprecations branch December 15, 2022 17:52
@firebase firebase locked and limited conversation to collaborators Jan 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@charlotteliang charlotteliang charlotteliang approved these changes

@ncooke3 ncooke3 ncooke3 approved these changes

Assignees

No one assigned

Labels

api: core public-api-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@paulb777 @google-oss-bot @charlotteliang @ncooke3