Skip to content

Persist FIRPhoneMultiFactorInfo (instead of FIRMultiFactorInfo) so that full phone number is always cached #10296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 4, 2022
Merged

Persist FIRPhoneMultiFactorInfo (instead of FIRMultiFactorInfo) so that full phone number is always cached #10296

merged 3 commits into from
Oct 4, 2022

Conversation

@renkelvin
Copy link
Contributor

@renkelvin renkelvin commented Oct 1, 2022 •
edited
Loading

Fix a bug where multi factor phone number returns NULL.

@google-oss-bot
Copy link

google-oss-bot commented Oct 1, 2022

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link

google-oss-bot commented Oct 1, 2022 •
edited
Loading

Size Report 1

Affected Products

  • FirebaseAuth

    TypeBase (f97888e)Merge (956481d)Diff
    CocoaPods?-51.5 kB? (?)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/cTjUffJj2z.html

@renkelvin renkelvin changed the title Initial commit Persist FIRPhoneMultiFactorInfo (instead of FIRMultiFactorInfo) so that full phone number is always cached Oct 3, 2022
@renkelvin renkelvin marked this pull request as ready for review October 3, 2022 16:17
@renkelvin renkelvin requested review from paulb777 and prameshj October 3, 2022 16:17
paulb777
paulb777 reviewed Oct 3, 2022
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix tests and if client visible, add a Changelog

@renkelvin
Copy link
Contributor Author

renkelvin commented Oct 4, 2022

Rerun fixed the CI failures. See the change log changes here: #10303

@renkelvin renkelvin merged commit 9ea83c8 into master Oct 4, 2022
@renkelvin renkelvin deleted the mfa-sms branch October 4, 2022 15:26
@mikehardy mikehardy mentioned this pull request Oct 28, 2022
Merged
8 tasks
@firebase firebase locked and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@paulb777 paulb777 paulb777 approved these changes

@prameshj prameshj prameshj approved these changes

Assignees

No one assigned

Labels

api: auth

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@renkelvin @google-oss-bot @paulb777 @prameshj