Add support of error MISSING_CLIENT_IDENTIFIER (#3341)

Author: renkelvin

Firebase/Auth/Source/Backend/FIRAuthBackend.m

@@ -1169,10 +1169,7 @@ + (nullable NSError *)clientErrorWithServerErrorMessage:(NSString *)serverErrorM
   }
 
   if ([shortErrorMessage isEqualToString:kMissingClientIdentifier]) {
-    return [FIRAuthErrorUtils appNotVerifiedErrorWithMessage:@"Missing app verification via"
-        " reCAPTCHA or APNS token. Please verify that appVerificationDisabledForTesting is not"
-        " enabled when testing with a phone number that is not marked as a test Phone number in the"
-        " app console."];
+    return [FIRAuthErrorUtils missingClientIdentifierErrorWithMessage:serverErrorMessage];
   }
 
   if ([shortErrorMessage isEqualToString:kCaptchaCheckFailedErrorMessage]) {

Firebase/Auth/Source/Public/FIRAuthErrors.h

@@ -335,6 +335,10 @@ typedef NS_ENUM(NSInteger, FIRAuthErrorCode) {
      */
     FIRAuthErrorCodeGameKitNotLinked = 17076,
 
+    /** Indicates an error for when the client identifier is missing.
+     */
+    FIRAuthErrorCodeMissingClientIdentifier = 17993,
+
     /** Indicates an error occurred while attempting to access the keychain.
      */
     FIRAuthErrorCodeKeychainError = 17995,

Firebase/Auth/Source/Utilities/FIRAuthErrorUtils.h

@@ -473,6 +473,13 @@ NS_ASSUME_NONNULL_BEGIN
  */
 + (NSError *)appNotVerifiedErrorWithMessage:(nullable NSString *)message;
 
+/** @fn missingClientIdentifierErrorWithMessage:
+    @brief Constructs an @c NSError with the @c FIRAuthErrorCodeMissingClientIdentifier code.
+    @param message Error message from the backend, if any.
+    @return The NSError instance associated with the given FIRAuthError.
+ */
++ (NSError *)missingClientIdentifierErrorWithMessage:(nullable NSString *)message;
+
 /** @fn captchaCheckFailedErrorWithMessage:
     @brief Constructs an @c NSError with the @c FIRAuthErrorCaptchaCheckFailed code.
     @param message Error message from the backend, if any.

Firebase/Auth/Source/Utilities/FIRAuthErrorUtils.m

@@ -157,6 +157,12 @@
     "keychain. The @c NSLocalizedFailureReasonErrorKey field in the @c NSError.userInfo dictionary "
     "will contain more information about the error encountered";
 
+/** @var kFIRAuthErrorMessageMissingClientIdentifier
+    @brief Message for @c FIRAuthErrorCodeMissingClientIdentifier error code.
+ */
+static NSString *const kFIRAuthErrorMessageMissingClientIdentifier = @"The request does not contain "
+    "any client identifier.";
+
 /** @var kFIRAuthErrorMessageUserTokenExpired
     @brief Message for @c FIRAuthErrorCodeTokenExpired error code.
  */
@@ -481,6 +487,8 @@
       return kFIRAuthErrorMessageNetworkError;
     case FIRAuthErrorCodeKeychainError:
       return kFIRAuthErrorMessageKeychainError;
+    case FIRAuthErrorCodeMissingClientIdentifier:
+      return kFIRAuthErrorMessageMissingClientIdentifier;
     case FIRAuthErrorCodeUserTokenExpired:
       return kFIRAuthErrorMessageUserTokenExpired;
     case FIRAuthErrorCodeUserNotFound:
@@ -614,6 +622,8 @@
       return @"ERROR_NETWORK_REQUEST_FAILED";
     case FIRAuthErrorCodeKeychainError:
       return @"ERROR_KEYCHAIN_ERROR";
+    case FIRAuthErrorCodeMissingClientIdentifier:
+      return @"ERROR_MISSING_CLIENT_IDENTIFIER";
     case FIRAuthErrorCodeUserTokenExpired:
       return @"ERROR_USER_TOKEN_EXPIRED";
     case FIRAuthErrorCodeUserNotFound:
@@ -1086,6 +1096,10 @@ + (NSError *)appNotVerifiedErrorWithMessage:(nullable NSString *)message {
   return [self errorWithCode:FIRAuthInternalErrorCodeAppNotVerified message:message];
 }
 
++ (NSError *)missingClientIdentifierErrorWithMessage:(nullable NSString *)message {
+  return [self errorWithCode:FIRAuthInternalErrorCodeMissingClientIdentifier message:message];
+}
+
 + (NSError *)captchaCheckFailedErrorWithMessage:(nullable NSString *)message {
   return [self errorWithCode:FIRAuthInternalErrorCodeCaptchaCheckFailed message:message];
 }

Firebase/Auth/Source/Utilities/FIRAuthInternalErrors.h

@@ -92,6 +92,12 @@ typedef NS_ENUM(NSInteger, FIRAuthInternalErrorCode) {
   FIRAuthInternalErrorCodeKeychainError =
       FIRAuthPublicErrorCodeFlag | FIRAuthErrorCodeKeychainError,
 
+  /** @var FIRAuthInternalErrorCodeMissingClientIdentifier
+      @brief Indicates an error for when the client identifier is missing.
+   */
+  FIRAuthInternalErrorCodeMissingClientIdentifier =
+      FIRAuthPublicErrorCodeFlag | FIRAuthErrorCodeMissingClientIdentifier,
+
   /** @var FIRAuthInternalErrorCodeInternalError
       @brief An internal error occurred.
       @remarks This value is here for consistency. It's also used to make the implementation of