Make a copy of sessionDetails to avoid the risk of losing object during acting on notification of sessionID change. (#8189)

Author: visumickey

FirebasePerformance/CHANGELOG.md

@@ -1,5 +1,6 @@
 # Version 8.2.0
 * Update log messages with proper log levels.
+* Fix a crash on FPRSessionDetails. (#8139)
 
 # Version 8.1.0
 * Firebase Performance logs now contain URLs to see the performance data on the Firebase console.

FirebasePerformance/Sources/AppActivity/FPRSessionDetails.m

@@ -33,6 +33,12 @@ - (instancetype)initWithSessionId:(NSString *)sessionId options:(FPRSessionOptio
   return self;
 }
 
+- (FPRSessionDetails *)copyWithZone:(NSZone *)zone {
+  FPRSessionDetails *detailsCopy = [[[self class] allocWithZone:zone] initWithSessionId:_sessionId
+                                                                                options:_options];
+  return detailsCopy;
+}
+
 - (NSUInteger)sessionLengthInMinutes {
   NSTimeInterval sessionLengthInSeconds = ABS([self.sessionCreationTime timeIntervalSinceNow]);
   return (sessionLengthInSeconds / 60);

FirebasePerformance/Sources/Instrumentation/FPRNetworkTrace.m

@@ -141,7 +141,7 @@ - (void)updateTraceWithCurrentSession {
   if (self.traceStarted && !self.traceCompleted) {
     dispatch_async(self.sessionIdSerialQueue, ^{
       FPRSessionManager *sessionManager = [FPRSessionManager sharedInstance];
-      FPRSessionDetails *sessionDetails = sessionManager.sessionDetails;
+      FPRSessionDetails *sessionDetails = [sessionManager.sessionDetails copy];
       if (sessionDetails) {
         [self.activeSessions addObject:sessionDetails];
       }

FirebasePerformance/Sources/Timer/FIRTrace.m

@@ -404,7 +404,7 @@ - (void)updateTraceWithSessionId {
   if ([self isTraceActive]) {
     dispatch_async(self.sessionIdSerialQueue, ^{
       FPRSessionManager *sessionManager = [FPRSessionManager sharedInstance];
-      FPRSessionDetails *sessionDetails = sessionManager.sessionDetails;
+      FPRSessionDetails *sessionDetails = [sessionManager.sessionDetails copy];
       if (sessionDetails) {
         [self.activeSessions addObject:sessionDetails];
       }