Skip to content

Commit 76a6983

Browse files
Remove pendingToken from public API. It's added to public header by mistake. (#2676)
Developers are not supposed to use it, and they currently have no way to use it.
1 parent 9854959 commit 76a6983

File tree

4 files changed

+5
-31
lines changed

4 files changed

+5
-31
lines changed

Firebase/Auth/Source/AuthProviders/OAuth/FIROAuthCredential_Internal.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,11 @@ NS_ASSUME_NONNULL_BEGIN
3535
*/
3636
@property(nonatomic, readonly, nullable) NSString *sessionID;
3737

38+
/** @property pendingToken
39+
@brief The pending token used when completing the headful-lite flow.
40+
*/
41+
@property(nonatomic, readonly, nullable) NSString *pendingToken;
42+
3843
/** @fn initWithProviderId:IDToken:accessToken:pendingToken
3944
@brief Designated initializer.
4045
@param providerID The provider ID associated with the credential being created.

Firebase/Auth/Source/AuthProviders/OAuth/FIROAuthProvider.m

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -64,16 +64,6 @@ @implementation FIROAuthProvider {
6464
NSString *_callbackScheme;
6565
}
6666

67-
+ (FIROAuthCredential *)credentialWithProviderID:(NSString *)providerID
68-
IDToken:(NSString *)IDToken
69-
accessToken:(nullable NSString *)accessToken
70-
pendingToken:(nullable NSString *)pendingToken {
71-
return [[FIROAuthCredential alloc] initWithProviderID:providerID
72-
IDToken:IDToken
73-
accessToken:accessToken
74-
pendingToken:pendingToken];
75-
}
76-
7767
+ (FIROAuthCredential *)credentialWithProviderID:(NSString *)providerID
7868
IDToken:(NSString *)IDToken
7969
accessToken:(nullable NSString *)accessToken {

Firebase/Auth/Source/Public/FIROAuthCredential.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,6 @@ NS_SWIFT_NAME(OAuthCredential)
3636
*/
3737
@property(nonatomic, readonly, nullable) NSString *accessToken;
3838

39-
/** @property pendingToken
40-
@brief The pending token used when completing the headful-lite flow.
41-
*/
42-
@property(nonatomic, readonly, nullable) NSString *pendingToken;
43-
4439
/** @fn init
4540
@brief This class is not supposed to be instantiated directly.
4641
*/

Firebase/Auth/Source/Public/FIROAuthProvider.h

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -72,22 +72,6 @@ NS_SWIFT_NAME(OAuthProvider)
7272
*/
7373
+ (FIROAuthProvider *)providerWithProviderID:(NSString *)providerID auth:(FIRAuth *)auth;
7474

75-
/** @fn credentialWithProviderID:IDToken:accessToken:
76-
@brief Creates an `FIRAuthCredential` for that OAuth 2 provider identified by providerID, ID
77-
token and access token.
78-
79-
@param providerID The provider ID associated with the Auth credential being created.
80-
@param IDToken The IDToken associated with the Auth credential being created.
81-
@param accessToken The accessstoken associated with the Auth credential be created, if
82-
available.
83-
@param pendingToken The pending token used when completing the headful-lite flow.
84-
@return A FIRAuthCredential for the specified provider ID, ID token and access token.
85-
*/
86-
+ (FIROAuthCredential *)credentialWithProviderID:(NSString *)providerID
87-
IDToken:(NSString *)IDToken
88-
accessToken:(nullable NSString *)accessToken
89-
pendingToken:(nullable NSString *)pendingToken;
90-
9175
/** @fn credentialWithProviderID:IDToken:accessToken:
9276
@brief Creates an `FIRAuthCredential` for that OAuth 2 provider identified by providerID, ID
9377
token and access token.

0 commit comments

Comments
 (0)