Skip to content

Commit 72833ca

Browse files
committed
add comment about b/388888512
1 parent 1721117 commit 72833ca

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

Firestore/core/src/util/string_format.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -66,6 +66,11 @@ class FormatArg final : public absl::AlphaNum {
6666
public:
6767
template <typename T>
6868
FormatArg(T&& value,
69+
// TODO(b/388888512) Remove the usage of StringifySink since it is not part
70+
// of absl's public API. Moreover, subclassing AlphaNum is not supported
71+
// either, so find a way to do this without these two caveats.
72+
// See https://github.com/firebase/firebase-ios-sdk/pull/14331 for a
73+
// partial proposal.
6974
absl::strings_internal::StringifySink&& sink =
7075
{}) // NOLINT(runtime/explicit)
7176
: FormatArg{std::forward<T>(value), std::move(sink),

0 commit comments

Comments
 (0)