Allow semicolon in file name (#1991)

Author: schmidt-sebastian

Example/Storage/Tests/Integration/FIRStorageIntegrationTests.m

@@ -198,6 +198,24 @@ - (void)testUnauthenticatedSimplePutData {
   [self waitForExpectations];
 }
 
+- (void)testUnauthenticatedSimplePutSpecialCharacter {
+  XCTestExpectation *expectation =
+      [self expectationWithDescription:@"testUnauthenticatedSimplePutDataEscapedName"];
+  FIRStorageReference *ref = [self.storage referenceWithPath:@"ios/public/-._~!$'()*,=:@&+;"];
+
+  NSData *data = [@"Hello World" dataUsingEncoding:NSUTF8StringEncoding];
+
+  [ref putData:data
+        metadata:nil
+      completion:^(FIRStorageMetadata *metadata, NSError *error) {
+        XCTAssertNotNil(metadata, "Metadata should not be nil");
+        XCTAssertNil(error, "Error should be nil");
+        [expectation fulfill];
+      }];
+
+  [self waitForExpectations];
+}
+
 - (void)testUnauthenticatedSimplePutDataInBackgroundQueue {
   XCTestExpectation *expectation =
       [self expectationWithDescription:@"testUnauthenticatedSimplePutDataInBackgroundQueue"];

Firebase/Storage/CHANGELOG.md

@@ -1,5 +1,6 @@
 # 3.0.3
 - [changed] Storage operations can now be scheduled and controlled from any thread (#1302, #1388).
+- [fixed] Fixed an issue that prevented uploading of files whose names include semicolons.
 
 # 3.0.2
 - [changed] Migrate to use FirebaseAuthInterop interfaces to access FirebaseAuth (#1660).

Firebase/Storage/FIRStorageUtils.m

@@ -29,9 +29,9 @@
 
 #import "GTMSessionFetcher.h"
 
-// This is the list at https://cloud.google.com/storage/docs/json_api/ without & and +.
+// This is the list at https://cloud.google.com/storage/docs/json_api/ without &, ; and +.
 NSString *const kGCSObjectAllowedCharacterSet =
-    @"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-._~!$'()*,;=:@";
+    @"ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789-._~!$'()*,=:@";
 
 @implementation FIRStorageUtils