Skip to content

Commit 53bce58

Browse files
committed
More verbose comments in FIRIAMClientInfoFetcher, call completion in case that FIS token is fetched, but FID fails
1 parent 72f47b6 commit 53bce58

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

FirebaseInAppMessaging/Sources/Flows/FIRIAMClientInfoFetcher.m

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ - (void)fetchFirebaseInstallationDataWithProjectNumber:(NSString *)projectNumber
5151
if (error) {
5252
FIRLogWarning(kFIRLoggerInAppMessaging, @"I-IAM190008", @"Error in fetching FID: %@",
5353
error.localizedDescription);
54+
completion(nil, tokenResult.authToken, error);
5455
} else {
5556
FIRLogDebug(kFIRLoggerInAppMessaging, @"I-IAM190009",
5657
@"Successfully in fetching both FID as %@ and FIS token as %@",

FirebaseInAppMessaging/Sources/Private/Analytics/FIRIAMClientInfoFetcher.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,9 @@
2121

2222
NS_ASSUME_NONNULL_BEGIN
2323
@interface FIRIAMClientInfoFetcher : NSObject
24-
// Fetch the up-to-date FID and FIS token data. Since it involves a server interaction,
25-
// completion callback is provided for receiving the result.
24+
// Fetch the up-to-date Firebase Installation ID (FID) and Firebase Installation Service (FIS) token
25+
// data. Since it involves a server interaction, completion callback is provided for receiving the
26+
// result.
2627
- (void)fetchFirebaseInstallationDataWithProjectNumber:(NSString *)projectNumber
2728
withCompletion:
2829
(void (^)(NSString *_Nullable FID,

0 commit comments

Comments
 (0)