Merge 7b125f6 into 3ed321f

Author: qdpham13

FirebaseRemoteConfig/CHANGELOG.md

@@ -1,3 +1,6 @@
+# 10.12.0
+- [fixed] Fix issue of real-time listeners not being properly removed. (#11458)
+- [fixed] Fix real-time fetches not being able to fetch the latest template due to an in-progress fetch. (#11465)
 # 10.7.0
 - [feature] Added support for real-time config updates. Use the new `addOnConfigUpdateListener` API to get
   real-time updates. Existing [`fetch`](https://firebase.google.com/docs/reference/swift/firebaseremoteconfig/api/reference/Classes/RemoteConfig#fetch)

FirebaseRemoteConfig/Sources/RCNConfigFetch.m

@@ -208,31 +208,6 @@ - (void)realtimeFetchConfigWithNoExpirationDuration:(NSInteger)fetchAttemptNumbe
     if (strongSelf == nil) {
       return;
     }
-
-    // Check if a fetch is already in progress.
-    // TODO: for this case should we still return a SUCCESS status?
-    if (strongSelf->_settings.isFetchInProgress) {
-      // Check if we have some fetched data.
-      if (strongSelf->_settings.lastFetchTimeInterval > 0) {
-        FIRLogDebug(kFIRLoggerRemoteConfig, @"I-RCN000052",
-                    @"A fetch is already in progress. Using previous fetch results.");
-        FIRRemoteConfigUpdate *update =
-            [self->_content getConfigUpdateForNamespace:self->_FIRNamespace];
-        return [strongSelf reportCompletionWithStatus:strongSelf->_settings.lastFetchStatus
-                                           withUpdate:update
-                                            withError:nil
-                                    completionHandler:nil
-                              updateCompletionHandler:completionHandler];
-      } else {
-        FIRLogError(kFIRLoggerRemoteConfig, @"I-RCN000053",
-                    @"A fetch is already in progress. Ignoring duplicate request.");
-        return [strongSelf reportCompletionWithStatus:FIRRemoteConfigFetchStatusFailure
-                                           withUpdate:nil
-                                            withError:nil
-                                    completionHandler:nil
-                              updateCompletionHandler:completionHandler];
-      }
-    }
     // Check whether cache data is within throttle limit.
     if ([strongSelf->_settings shouldThrottle] && !hasDeviceContextChanged) {
       // Must set lastFetchStatus before FailReason.