Skip to content

Commit 2331dab

Browse files
authored
Disable code coverage report in PRs for external users (#7484)
1 parent 02bea53 commit 2331dab

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

.github/workflows/test_coverage.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -275,6 +275,7 @@ jobs:
275275
steps:
276276
- uses: actions/checkout@v2
277277
- name: Access to Metrics Service
278+
if: env.metrics_service_secret
278279
run: |
279280
# Install gcloud sdk
280281
curl https://sdk.cloud.google.com > install.sh
@@ -291,7 +292,7 @@ jobs:
291292
with:
292293
path: /Users/runner/test
293294
- name: Compare Diff and Post a Report
294-
if: github.event_name == 'pull_request'
295+
if: github.event_name == 'pull_request' && env.metrics_service_secret
295296
env:
296297
base_commit: ${{ needs.check.outputs.base_commit }}
297298
run: |
@@ -302,7 +303,7 @@ jobs:
302303
swift run CoverageReportGenerator --presubmit "firebase/firebase-ios-sdk" --commit "${GITHUB_SHA}" --token $(gcloud auth print-identity-token) --xcresult-dir "/Users/runner/test/codecoverage" --log-link "https://github.com/firebase/firebase-ios-sdk/actions/runs/${GITHUB_RUN_ID}" --pull-request-num ${{github.event.pull_request.number}} --base-commit "$base_commit"
303304
fi
304305
- name: Update New Coverage Data
305-
if: github.event.pull_request.merged == true
306+
if: github.event.pull_request.merged == true && env.metrics_service_secret
306307
run: |
307308
if [ -d "${{steps.download.outputs.download-path}}" ]; then
308309
cd scripts/code_coverage_report/generate_code_coverage_report

0 commit comments

Comments
 (0)