[Messaging] Rename initWithFileName internal method

Author: paulb777

FirebaseMessaging/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 10.29.0
+- [fixed] Renamed "initWithFileName" internal method that was causing submission issues for some
+  users. (#13134).
+
 # 10.27.0
 - [fixed] Fixed bug preventing Messaging from working with a custom sqlite3
   dependency (#12900).

FirebaseMessaging/Sources/Token/FIRMessagingBackupExcludedPlist.h

@@ -39,7 +39,7 @@
  *
  *  @return Helper which allows to read write data to a backup excluded plist.
  */
-- (instancetype)initWithFileName:(NSString *)fileName subDirectory:(NSString *)subDirectory;
+- (instancetype)initWithPlistFile:(NSString *)fileName subDirectory:(NSString *)subDirectory;
 
 /**
  *  Write dictionary data to the backup excluded plist file. If the file does not exist

FirebaseMessaging/Sources/Token/FIRMessagingBackupExcludedPlist.m

@@ -28,7 +28,7 @@ @interface FIRMessagingBackupExcludedPlist ()
 
 @implementation FIRMessagingBackupExcludedPlist
 
-- (instancetype)initWithFileName:(NSString *)fileName subDirectory:(NSString *)subDirectory {
+- (instancetype)initWithPlistFile:(NSString *)fileName subDirectory:(NSString *)subDirectory {
   self = [super init];
   if (self) {
     _fileName = [fileName copy];

FirebaseMessaging/Sources/Token/FIRMessagingCheckinStore.m

@@ -48,7 +48,7 @@ - (instancetype)init {
   self = [super init];
   if (self) {
     _plist = [[FIRMessagingBackupExcludedPlist alloc]
-        initWithFileName:kCheckinFileName
+        initWithPlistFile:kCheckinFileName
             subDirectory:kFIRMessagingInstanceIDSubDirectoryName];
     _keychain =
         [[FIRMessagingAuthKeychain alloc] initWithIdentifier:kFIRMessagingCheckinKeychainGeneric];

FirebaseMessaging/Tests/UnitTests/FIRMessagingBackupExcludedPlistTest.m

@@ -44,7 +44,7 @@ @implementation FIRMessagingBackupExcludedPlistTest
 - (void)setUp {
   [super setUp];
   [FIRMessaging createSubDirectory:kSubDirectoryName];
-  self.plist = [[FIRMessagingBackupExcludedPlist alloc] initWithFileName:kTestPlistFileName
+  self.plist = [[FIRMessagingBackupExcludedPlist alloc] initWithPlistFile:kTestPlistFileName
                                                             subDirectory:kSubDirectoryName];
 }
 

FirebaseMessaging/Tests/UnitTests/FIRMessagingCheckinStoreTest.m

@@ -67,7 +67,7 @@ - (void)setUp {
   [super setUp];
   [FIRMessaging createSubDirectory:kSubDirectoryName];
   self.checkinStore = [[FIRMessagingCheckinStore alloc] init];
-  self.plist = [[FIRMessagingBackupExcludedPlist alloc] initWithFileName:kFakeCheckinPlistName
+  self.plist = [[FIRMessagingBackupExcludedPlist alloc] initWithPlistFile:kFakeCheckinPlistName
                                                             subDirectory:kSubDirectoryName];
   self.checkinStore.plist = self.plist;
 }

FirebaseMessaging/Tests/UnitTests/FIRMessagingTokenStoreTest.m

@@ -76,7 +76,7 @@ - (void)setUp {
   [FIRMessaging createSubDirectory:kSubDirectoryName];
 
   self.checkinPlist =
-      [[FIRMessagingBackupExcludedPlist alloc] initWithFileName:kFakeCheckinPlistName
+      [[FIRMessagingBackupExcludedPlist alloc] initWithPlistFile:kFakeCheckinPlistName
                                                    subDirectory:kSubDirectoryName];
 
   // checkin store